Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Gin binding tag in favor of manually checking for project ID #10

Merged
merged 1 commit into from
Apr 30, 2021
Merged

use Gin binding tag in favor of manually checking for project ID #10

merged 1 commit into from
Apr 30, 2021

Conversation

billiford
Copy link
Collaborator

  • remove code to check for required field projectID when creating credentials in favor of using Gin's required binding struct tag

dmrogers7
dmrogers7 approved these changes Apr 30, 2021
View reviewed changes
Copy link
Collaborator

@dmrogers7 dmrogers7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@dmrogers7 dmrogers7 merged commit 5f3eaac into main Apr 30, 2021
@dmrogers7 dmrogers7 deleted the use-gin-binding-tag branch April 30, 2021 11:12
mackenzie-orange pushed a commit to quotecenter/cloud-runner that referenced this pull request Aug 30, 2021
@wxb5639
[#177567198] fix list credentials response (homedepot#10)
e9a8a81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmrogers7 dmrogers7 dmrogers7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billiford @dmrogers7