Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ip dependency #18

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Remove ip dependency #18

merged 4 commits into from
Feb 14, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 14, 2024

♻️ Current situation

There is an open security vulnerability in the ip package in the isPublic method. While this doesn't impact us, as we are just using the ip package within our tests (and only the isV4Format), we don't really need this dependency. This package doesn't seem to be maintained anymore.

💡 Proposed solution

Remove dependence on node-ip package. This resolves #17.

⚙️ Release Notes

  • Remove dependence on node-ip package
  • Updated all dependencies
  • Upgraded to organization wide GitHub actions

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7907540595

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.73%

Totals Coverage Status
Change from base Build 3088795793: 0.0%
Covered Lines: 357
Relevant Lines: 394

💛 - Coveralls

@Supereg Supereg merged commit 2ba464f into master Feb 14, 2024
8 checks passed
@Supereg Supereg deleted the fix/remove-ip-dependency branch February 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High severity vulnerability in dependency (ip 1.1.8)
2 participants