Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv instead of pip in Supervisor #5152

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Use uv instead of pip in Supervisor #5152

merged 4 commits into from
Jul 3, 2024

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Jun 24, 2024

Proposed change

Switch supervisor over to uv installer instead of pip for performance and consistency with core.

Depends on home-assistant/devcontainer#87 for startup script split in devcontainer. However this PR does not update devcontainer to use uv as that has issues which need to be resolved first.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Summary by CodeRabbit

  • Chores
    • Improved Docker setup by adding UV_SYSTEM_PYTHON=true environment variable and using uv for package management.
    • Updated .devcontainer/devcontainer.json to refine commands and settings for a more efficient development environment, including paths, testing, and linting configurations.

@mdegat01 mdegat01 added the refactor A code change that neither fixes a bug nor adds a feature label Jun 24, 2024
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdegat01 mdegat01 marked this pull request as ready for review June 25, 2024 20:57
Copy link

coderabbitai bot commented Jun 25, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent updates streamline the Docker setup by introducing the UV_SYSTEM_PYTHON environment variable, upgrading the way Python packages are installed using the uv tool, and tailoring the build process for different architectures. Additionally, development container configurations are refined for improved setup and environment activation.

Changes

File Change Summary
Dockerfile Added UV_SYSTEM_PYTHON, installed uv package, replaced pip3 with uv pip for package installations. Adjusted commands to handle different architectures.
.devcontainer/devcontainer.json Updated postCreateCommand, added postStartCommand, set Python paths, and configured linting, testing, and editor settings.

Sequence Diagram(s)

No sequence diagrams are needed for these changes as they primarily involve environment setup and configuration adjustments.

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@agners agners marked this pull request as draft June 27, 2024 08:10
@mdegat01 mdegat01 force-pushed the supervisor-pip-to-uv branch 3 times, most recently from 59a01ab to 0423c44 Compare July 3, 2024 15:24
@mdegat01 mdegat01 force-pushed the supervisor-pip-to-uv branch from 0423c44 to c8b1baf Compare July 3, 2024 15:26
@mdegat01 mdegat01 requested a review from pvizeli July 3, 2024 15:30
@mdegat01 mdegat01 marked this pull request as ready for review July 3, 2024 15:51
@mdegat01 mdegat01 merged commit 02bdc4b into main Jul 3, 2024
19 checks passed
@mdegat01 mdegat01 deleted the supervisor-pip-to-uv branch July 3, 2024 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants