Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount manager reload mounts all failed mounts #5014

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

mdegat01
Copy link
Contributor

Proposed change

Mount manager reload is currently called every 15 minutes to get an update on the state of all mounts. Currently it only attempts to reload or mount a failed mount on first failure, after that it pops a repair and leaves it up to the user to fix.

Now it will attempt reload of all failures anytime it is reloaded. This will help users that don't run a NAS 24/7 and turn it off on certain times and days. Currently if those users happen to reboot or update supervisor at that time they have to manually fix it after turning on their NAS, now Supervisor will fix it for them eventually (15 minutes max).

The downside here is there will be a lot more logging. If a NAS is actually down long-term and the mount is still configured in Supervisor it will keep trying and logging the failure every 15 minutes. But considering we have a good number of requests from users in the first situation, it seems like a worthwhile trade off.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the new-feature A new feature label Apr 11, 2024
@mdegat01 mdegat01 requested a review from agners April 11, 2024 19:15
@mdegat01 mdegat01 force-pushed the reload-restores-mounts branch from 1c269cc to c2c11e6 Compare April 11, 2024 19:37
@agners agners merged commit dfd8fe8 into main Apr 12, 2024
19 checks passed
@agners agners deleted the reload-restores-mounts branch April 12, 2024 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants