Mount manager reload mounts all failed mounts #5014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Mount manager reload is currently called every 15 minutes to get an update on the state of all mounts. Currently it only attempts to reload or mount a failed mount on first failure, after that it pops a repair and leaves it up to the user to fix.
Now it will attempt reload of all failures anytime it is reloaded. This will help users that don't run a NAS 24/7 and turn it off on certain times and days. Currently if those users happen to reboot or update supervisor at that time they have to manually fix it after turning on their NAS, now Supervisor will fix it for them eventually (15 minutes max).
The downside here is there will be a lot more logging. If a NAS is actually down long-term and the mount is still configured in Supervisor it will keep trying and logging the failure every 15 minutes. But considering we have a good number of requests from users in the first situation, it seems like a worthwhile trade off.
Type of change
Additional information
Checklist
ruff format supervisor tests
)If API endpoints of add-on configuration are added/changed: