Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon load should not fail due to docker error #5011

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mdegat01
Copy link
Contributor

Proposed change

An error while pulling or building the image for an addon during load should not cause setup to fail, these should not raise out of load.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Apr 10, 2024
@mdegat01 mdegat01 requested a review from agners April 10, 2024 18:22
@agners agners merged commit f0e2fb3 into main Apr 11, 2024
20 checks passed
@agners agners deleted the addon-load-suppress-docker-error branch April 11, 2024 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup failed after updating to 2024.4.1
2 participants