Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt a disabled data disk #5010

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Adopt a disabled data disk #5010

merged 1 commit into from
Apr 11, 2024

Conversation

mdegat01
Copy link
Contributor

Proposed change

Allow adopting a data disk that was disabled at first boot of HAOS. Also prompt users to rename it to hassos-data-old if they don't want to adopt it so we know that and the repair won't come back.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the new-feature A new feature label Apr 10, 2024
@mdegat01 mdegat01 requested a review from agners April 10, 2024 17:49
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdegat01 mdegat01 merged commit 672a762 into main Apr 11, 2024
20 checks passed
@mdegat01 mdegat01 deleted the adopt-data-disk-dis branch April 11, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants