Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIForbidden should result in 403 status #4943

Merged
merged 1 commit into from
Mar 4, 2024
Merged

APIForbidden should result in 403 status #4943

merged 1 commit into from
Mar 4, 2024

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Mar 4, 2024

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Mar 4, 2024
@mdegat01 mdegat01 requested a review from agners March 4, 2024 15:27
@mdegat01 mdegat01 merged commit 2c7b417 into main Mar 4, 2024
19 checks passed
@mdegat01 mdegat01 deleted the forbidden-is-403 branch March 4, 2024 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants