Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass explicit architecture of installed add-ons #4786

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

agners
Copy link
Member

@agners agners commented Dec 21, 2023

Proposed change

When using multi-architecture container images, the architecture of the add-on is not passed to Docker in all cases. This causes the architecture of the Supervisor container to be used, which potentially is not supported by the add-on in question.

This commit passes the architecture of the add-on to Docker, so that the correct image is pulled.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

When using multi-architecture container images, the architecture of the
add-on is not passed to Docker in all cases. This causes the
architecture of the Supervisor container to be used, which potentially
is not supported by the add-on in question.

This commit passes the architecture of the add-on to Docker, so that
the correct image is pulled.
@mdegat01 mdegat01 force-pushed the pass-architecture-on-add-on-update branch from 829e141 to a32e5a3 Compare December 21, 2023 21:38
@mdegat01 mdegat01 merged commit 3e760f0 into main Dec 21, 2023
22 of 23 checks passed
@mdegat01 mdegat01 deleted the pass-architecture-on-add-on-update branch December 21, 2023 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error updating ESPHome: Can't install ghcr.io/esphome/esphome-hassio:2023.4.3
2 participants