Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aiohttp to 3.9.1 #4729

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Bump aiohttp to 3.9.1 #4729

merged 2 commits into from
Nov 27, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 27, 2023

Proposed change

Bump aiohttp to 3.9.1
changelog: aio-libs/aiohttp@v3.8.6...v3.9.1

The issues that caused us to revert 3.9.0 have been fixed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@bdraco
Revert "Revert "Bump aiohttp to 3.9.0 (#4714)" (#4722)"
619373c 
This reverts commit c0868d9.
@bdraco
Bump aiohttp to 3.9.1
9bce206 
changelog: aio-libs/aiohttp@v3.8.6...v3.9.1

The issues that caused us to revert 3.9.0 have been fixed
@bdraco bdraco added the dependencies Updates of external dependencies label Nov 27, 2023
@bdraco bdraco marked this pull request as ready for review November 27, 2023 00:51
frenck
frenck approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Thanks, @bdraco

../Frenck

@pvizeli pvizeli merged commit cb03d03 into main Nov 27, 2023
22 of 23 checks passed
@pvizeli pvizeli deleted the aiohttp_391 branch November 27, 2023 12:44
@bdraco
Copy link
Member Author

bdraco commented Nov 27, 2023

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed dependencies Updates of external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @frenck @pvizeli