Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingress session cleanup #4719

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix ingress session cleanup #4719

merged 1 commit into from
Nov 21, 2023

Conversation

mdegat01
Copy link
Contributor

Proposed change

Ingress session cleanup was adding None into data when we had a session with no session data (which is common). This created a lot of issues when we attempted to save ingress data since None is invalid at that spot.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added the bugfix A bug fix label Nov 21, 2023
@mdegat01 mdegat01 merged commit c74f87c into main Nov 21, 2023
23 of 24 checks passed
@mdegat01 mdegat01 deleted the fix-ingress-cleanup branch November 21, 2023 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants