Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty newlines in Supervisor logs #4698

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

agners
Copy link
Member

@agners agners commented Nov 11, 2023

Proposed change

It seems that the bashio ping command leads to empty newlines in the Supervisor logs. Redirecting its stdout to /dev/null avoids these empty newlines.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

It seems that the bashio ping command leads to empty newlines in the
Supervisor logs. Redirecting its stdout to /dev/null avoids these empty
newlines.
@agners agners added the bugfix A bug fix label Nov 11, 2023
@agners agners requested a review from frenck November 11, 2023 21:40
@agners
Copy link
Member Author

agners commented Nov 11, 2023

@frenck not sure if that is intended behavior of bashio. Maybe the better fix is to silence bashio in this case? 🤔

@frenck
Copy link
Member

frenck commented Nov 13, 2023

Let's add this for now. I'll take a look, it should not provide new lines (it never did before?)

../Frenck

@frenck frenck merged commit 9351796 into main Nov 13, 2023
24 checks passed
@frenck frenck deleted the avoid-empty-newlines-in-su-log branch November 13, 2023 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants