Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log entries of level INFO to Sentry breadcrumbs #4676

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

agners
Copy link
Member

@agners agners commented Nov 7, 2023

Proposed change

This gives better insight for certain issues as more log entries are available in the breadcrumbs of captured Sentry issues.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@agners agners added the new-feature A new feature label Nov 7, 2023
This gives better insight for certain issues as more log entries are
available in the breadcrumbs of captured Sentry issues.
@agners agners force-pushed the add-more-breadcrumbs-in-sentry branch from c3c4395 to fac64b3 Compare November 8, 2023 10:44
@frenck frenck merged commit d634273 into main Nov 8, 2023
20 checks passed
@frenck frenck deleted the add-more-breadcrumbs-in-sentry branch November 8, 2023 11:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants