Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Home Assistant Core API check #4663

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix Home Assistant Core API check #4663

merged 2 commits into from
Nov 2, 2023

Conversation

agners
Copy link
Member

@agners agners commented Nov 2, 2023

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@agners agners added the bugfix A bug fix label Nov 2, 2023
@agners agners marked this pull request as ready for review November 2, 2023 11:40
@pvizeli pvizeli merged commit 6f01341 into main Nov 2, 2023
22 of 23 checks passed
@pvizeli pvizeli deleted the fix-api-check branch November 2, 2023 12:21
@mdegat01
Copy link
Contributor

mdegat01 commented Nov 2, 2023

We really need test cases around this. The things that are mocked universally in the coresys fixture are always bound to bite us eventually. I'll see what I can do about this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants