Use longer timeouts for API checks before trigger a rollback

[agners]

Proposed change

Currently we check for Core API access and that the state is running. If this is not fulfilled within 5 minutes, we rollback to the previous version.

It can take quite a while until Home Assistant Core is in state running. In fact, after going through bootstrap, it can theoretically take indefinitely (as in there is no timeout from Core side).

So to trigger rollback, rather than check the state to be running, just check if the API is accessible in this case. This prevents spurious rollbacks.

However, we can almost guarantee that with all timeouts added up, and some margin, the Core should be up in all but the most obscure setups.

Use a two step method, where we check the API responding first before checking the state. This allows to better understand why the Supervisor chose to rollback, and rolls back the system faster in case there is a serious problem.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (which adds functionality to the supervisor)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Supervisor's 'Core hasn't started' API timeout check seems to be firing every time #4655
• This PR is related to issue:
• Link to documentation pull request:
• Link to cli pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast supervisor tests)
• Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

• Documentation added/updated for developers.home-assistant.io

[bdraco]

unrelated

        # Check if port is up
        if not await self.sys_run_in_executor(
            check_port,
            self.sys_homeassistant.ip_address,
            self.sys_homeassistant.api_port,
        ):
            return False

Thats a bit unexpected to run in the executor as it could be all non-blocking

[bdraco]

LGTM 👍

[mdegat01]

Thanks @agners and @bdraco ! 👍