Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstarted jobs should always be cleaned up #4604

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Oct 5, 2023

Proposed change

Currently jobs which are never started because they fail the limit or condition checks are left around indefinitely. These should always be cleaned up and removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli merged commit ace58ba into main Oct 9, 2023
@pvizeli pvizeli deleted the cleanup-unstarted-jobs branch October 9, 2023 09:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supervisor Jobs that never run
2 participants