Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobGroups check active job to determine if in progress #4602

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Oct 4, 2023

Proposed change

Descendents of Job Groups do not use a a lock member on the class to track whether a task is in progress, they ask the job group if there's an active job. This currently creates issues like JobGroupExecutionLimitExceeded: Another job is running for job group container_hassio_observer from plugin watchdog as it does not know another job is already happening.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, with this change we can learn if a job is in progress and handle this cases more gracefully, so the exceptions don't show up anymore. Nice catch!

@pvizeli pvizeli merged commit d70aa5f into main Oct 4, 2023
@pvizeli pvizeli deleted the fix-in-progess-for-groups branch October 4, 2023 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants