Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in docstrings #4546

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Fix typos in docstrings #4546

merged 4 commits into from
Sep 26, 2023

Conversation

ChrisCarini
Copy link
Contributor

@ChrisCarini ChrisCarini commented Sep 10, 2023

Proposed change

  • [typo] an -> a
  • [typo] Assitant -> Assistant

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@home-assistant
Copy link

Hi @ChrisCarini

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@agners
Copy link
Member

agners commented Sep 11, 2023

These are quite different changes. Can you split the Python change to a separate PR?

@ChrisCarini ChrisCarini changed the title [typo] Assitant -> Assistant; an -> a; Update PyPi classifier to Python 3.11 [typo] Assitant -> Assistant; an -> a Sep 21, 2023
@ChrisCarini
Copy link
Contributor Author

These are quite different changes. Can you split the Python change to a separate PR?

@agners - happily! Just dropped the respective commit and force-pushed this branch, and also opened #4574 to update the classifier on pypi. Please re-review when you have a moment!

@agners agners added the chore label Sep 21, 2023
@ChrisCarini
Copy link
Contributor Author

Thank you for the approval @agners ! Will this PR get auto-merged, or does it need to be manually merged in?

@ChrisCarini ChrisCarini requested a review from agners September 25, 2023 22:02
@agners agners changed the title [typo] Assitant -> Assistant; an -> a Fix typos in docstrings Sep 26, 2023
@agners agners merged commit f5afe13 into home-assistant:main Sep 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants