Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CAP_BPF and CAP_PERFMON privileges #4259

Merged
merged 4 commits into from
May 21, 2023

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Apr 24, 2023

Proposed change

Add support for setting the CAP_BPF and CAP_PERFMON capabilities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@felipecrs
Copy link
Contributor Author

I'll craft the documentation PR as soon as I get a go ahead on this PR.

BTW this is a continuation of #4130, which could not be done at that time because of the version of Docker.

@felipecrs
Copy link
Contributor Author

supervisor/addons/utils.py Outdated Show resolved Hide resolved
supervisor/docker/const.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 27, 2023 12:24
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@felipecrs felipecrs marked this pull request as ready for review April 27, 2023 12:27
@home-assistant home-assistant bot requested a review from agners April 27, 2023 12:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @felipecrs 👍

../Frenck

@frenck frenck merged commit 88d25fc into home-assistant:main May 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
@felipecrs felipecrs deleted the cap-perfmon branch November 6, 2023 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants