Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boards APIs #3984

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Add boards APIs #3984

merged 2 commits into from
Nov 4, 2022

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Nov 3, 2022

Proposed change

Add /os/boards/{Board} APIs to allow control of board features. Primarily for enabling/disabling LEDs on the yellow board for now but will be used for other things in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added missing-documentation Added to pull requests that needs a docs, but none is linked new-feature A new feature need-cli Added to pull requests that need cli changes but none is linked labels Nov 3, 2022
supervisor/dbus/manager.py Outdated Show resolved Hide resolved
@mdegat01
Copy link
Contributor Author

mdegat01 commented Nov 3, 2022

@pvizeli Fixed. Also while I was in there, adopted the pattern used here into agent:

@property
def all(self) -> list[DBusInterface]:
"""Return all managed dbus interfaces."""
return [
self.agent,
self.systemd,
self.logind,
self.hostname,
self.timedate,
self.network,
self.rauc,
self.resolved,
]

Figured it was fine to load all these child interfaces in parallel, let me know if that poses a problem.

@pvizeli pvizeli merged commit 672b220 into main Nov 4, 2022
@pvizeli pvizeli deleted the add-boards-apis branch November 4, 2022 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed missing-documentation Added to pull requests that needs a docs, but none is linked need-cli Added to pull requests that need cli changes but none is linked new-feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants