Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect capitialization of network interfaces #3646

Conversation

agners
Copy link
Member

@agners agners commented May 18, 2022

Proposed change

Don't assume network interface names are always lower case. It seems
that they can have an upper case letter, and capitalization matters.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@agners agners added the bugfix A bug fix label May 18, 2022
@agners agners changed the title Resepect capitialization of network interfaces Respect capitialization of network interfaces May 18, 2022
Copy link
Contributor

@mdegat01 mdegat01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea was just looking at this issue. Just searched and it does look like this is the only place we do this which is good.

Technically this is a breaking change. It won't affect the UI since that doesn't let the user enter the interface name manually. But the CLI and API do. I don't think we really have a choice though and should be minor.

@agners
Copy link
Member Author

agners commented May 19, 2022

Technically this is a breaking change. It won't affect the UI since that doesn't let the user enter the interface name manually. But the CLI and API do. I don't think we really have a choice though and should be minor.

Yeah well, the Ethernet interface names under Linux are case sensitive, and the CLI handles it now correctly 🤷‍♂️ . A feature and bug is sometimes a fine line 😅

@agners agners merged commit 2fe358f into home-assistant:main May 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface enx0 does not exist
3 participants