Enable TCPMSS target iptables module for all boards #3739
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to kernel configuration files across different builds. Notably, the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
buildroot-external/kernel/v6.6.y/hassos.config (1)
158-158: Configuration is well-integrated with the networking stack.The TCPMSS target module is properly integrated within the broader networking configuration:
- Sits correctly among other netfilter target modules
- Complements existing WireGuard support (CONFIG_WIREGUARD=m)
- All necessary networking features are enabled for proper operation
The modular approach (=m) allows for dynamic loading when needed, which is optimal for resource utilization.
Also applies to: 142-157, 159-171
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
buildroot-external/board/asus/tinker/kernel.config(0 hunks)buildroot-external/kernel/v6.6.y/hassos.config(1 hunks)buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config(0 hunks)
💤 Files with no reviewable changes (2)
- buildroot-external/board/asus/tinker/kernel.config
- buildroot-external/kernel/v6.6.y/kernel-arm64-rockchip.config
🔇 Additional comments (1)
buildroot-external/kernel/v6.6.y/hassos.config (1)
158-158: LGTM! The TCPMSS target configuration is correctly added.
The addition of CONFIG_NETFILTER_XT_TARGET_TCPMSS=m as a loadable module is properly placed in the netfilter configuration section and aligns with the PR's objective to enable TCPMSS target support across all boards.
Let's verify the configuration dependencies are met:
✅ Verification successful
TCPMSS target module is properly configured with all required dependencies
The verification confirms:
- TCPMSS target is correctly set as a loadable module (
CONFIG_NETFILTER_XT_TARGET_TCPMSS=m) - All required netfilter dependencies are present and properly configured
- The configuration is consistent across board configs
- Related networking features (WireGuard, IP sets, netfilter core) are properly enabled
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that all required dependencies for TCPMSS target are present
# Expected: Should find CONFIG_NETFILTER_XT_TARGET_TCPMSS and its dependencies
# Check for the main config and related networking configs
rg -A 5 'CONFIG_NETFILTER|CONFIG_IP_SET|CONFIG_WIREGUARD' buildroot-external/kernel/v6.6.y/hassos.config
# Check other board configs to ensure consistency
fd -e config -x rg 'CONFIG_NETFILTER_XT_TARGET_TCPMSS'
Length of output: 953
issues with wireguard support on different platforms. This refs home-assistant/operating-system#3739
The TCPMSS target module for iptables was enabled in some kernel defconfigs but not for all targets. It is used e.g. in default config of @bigmoby's WireGuard Client add-on. Enable it globally in the HAOS kernel config to make sure it's always present.
Fixes #3730
Summary by CodeRabbit
New Features
Bug Fixes
These updates improve hardware compatibility, memory management, and overall system security.