Add Hailo PCIe driver and firmware for x86-64, aarch64 and OVA #3736
Conversation
Hailo modules are usable also in other generic targets, so enable them also on generic x86 and ARM targets. Runtime tested only on x86-64 (Beelink with Intel N100).
sairon
added
board/ova
📝 WalkthroughWalkthroughThe changes involve the addition of two new packages, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
buildroot-external/configs/ova_defconfig (1)
Line range hint
173-174: Consider documenting platform-specific requirementsGiven that this change adds Hailo support across multiple architectures and deployment scenarios (physical and virtual), consider:
- Documenting platform-specific requirements and limitations
- Adding configuration validation to ensure Hailo packages are only enabled on supported platforms
- Creating platform-specific setup guides for each supported architecture
This will help users understand the requirements and limitations for their specific deployment scenario.
Also applies to: 177-178, 178-179
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
buildroot-external/configs/generic_aarch64_defconfig(1 hunks)buildroot-external/configs/generic_x86_64_defconfig(1 hunks)buildroot-external/configs/ova_defconfig(1 hunks)
🔇 Additional comments (4)
buildroot-external/configs/generic_aarch64_defconfig (2)
173-174: Verify testing on aarch64 platform
While the changes have been tested on x86-64, the PR description doesn't mention testing status for aarch64. Please confirm that the driver and firmware have been tested on an aarch64 platform.
173-174: LGTM - Package additions are consistent with PR objectives
The addition of Hailo firmware and PCIe driver packages aligns with the goal of adding Hailo support.
Let's verify the kernel configuration includes necessary PCIe support:
✅ Verification successful
PCIe support is properly configured for Hailo integration
The kernel configuration includes comprehensive PCIe support with all necessary components:
- Base PCIe subsystem (
CONFIG_PCI=y) - PCIe port bus support (
CONFIG_PCIEPORTBUS=y) - PCIe Advanced Error Reporting (
CONFIG_PCIEAER=y) - PCIe hotplug support (
CONFIG_HOTPLUG_PCI=y) - Generic PCIe host controller support (
CONFIG_PCI_HOST_GENERIC=y) - Various platform-specific PCIe drivers
The existing PCIe infrastructure will properly support the Hailo PCIe driver and firmware packages.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check kernel config fragments for PCIe support
# Expected: Should find PCIe-related configurations
rg -l "CONFIG.*PCI.*=y" "$(BR2_EXTERNAL_HASSOS_PATH)/kernel/v6.6.y/device-support-pci.config"
Length of output: 290
Script:
#!/bin/bash
# Let's first find the correct path to kernel config files
fd "device-support-pci.config" --type f
# Then check for PCI configs in all kernel config files to be thorough
fd ".config$" --type f --exec rg "CONFIG.*PCI.*=y" {}
Length of output: 1712
buildroot-external/configs/generic_x86_64_defconfig (1)
177-178: LGTM - Verified working on x86-64 platform
The changes have been tested successfully on a Beelink N100 device, and the configuration includes all necessary PCIe support.
buildroot-external/configs/ova_defconfig (1)
178-179: Clarify use case for Hailo support in OVA
The addition of Hailo support to the OVA configuration raises some questions:
- Is Hailo PCIe passthrough supported/tested in virtual environments?
- What is the intended use case for Hailo acceleration in OVA deployments?
Please confirm if this has been tested in virtual environments and provide details about the intended usage scenario.
Hailo modules are usable also in other generic targets, so enable them also on generic x86 and ARM targets. Runtime tested only on x86-64 (Beelink with Intel N100).
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor
Style
Tests
Chores
Revert