Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Update kernel to 6.6.65 #3733

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Linux: Update kernel to 6.6.65 #3733

merged 1 commit into from
Dec 11, 2024

Conversation

sairon
Copy link
Member

@sairon sairon commented Dec 11, 2024

Summary by CodeRabbit

  • New Features
    • Updated kernel version to 6.6.65 for multiple platforms, including Open Virtual Appliance, Home Assistant Green, Tinker Board, and various ODROID models.
  • Bug Fixes
    • Improvements and fixes associated with the new kernel version may enhance system stability and performance across supported devices.

@sairon sairon added board/ova Open Virtual Appliance (Virtual Machine) board/odroid Hardkernel's ODROID Boards board/tinker ASUS' Tinker Boards linux Linux kernel related issue board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) board/khadas Khadas VIM Boards board/generic-aarch64 Generic aarch64 machine board/green Home Assistant Green labels Dec 11, 2024
@sairon sairon requested a review from agners December 11, 2024 17:53
Copy link

coderabbitai bot commented Dec 11, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request involve updating the Linux kernel version from 6.6.64 to 6.6.65 across various configuration files and documentation related to multiple hardware platforms. The updates are primarily reflected in the Documentation/kernel.md file and several configuration files in the Buildroot external repository. No other configuration options or settings were altered, maintaining the existing structure and parameters.

Changes

File Path Change Summary
Documentation/kernel.md Updated kernel version for multiple boards from 6.6.64 to 6.6.65.
buildroot-external/configs/generic_aarch64_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/generic_x86_64_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/green_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/khadas_vim3_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/odroid_c2_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/odroid_c4_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/odroid_m1_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/odroid_m1s_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/odroid_n2_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/odroid_xu4_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/ova_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.
buildroot-external/configs/tinker_defconfig Updated BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.64 to 6.6.65.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
buildroot-external/configs/odroid_m1s_defconfig (1)

Line range hint 169-169: Fix: Incorrect HASSIO_MACHINE value for Odroid M1S

The HASSIO_MACHINE value is set to "odroid-m1" but should be "odroid-m1s" for this board configuration.

-BR2_PACKAGE_HASSIO_MACHINE="odroid-m1"
+BR2_PACKAGE_HASSIO_MACHINE="odroid-m1s"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 434b837 and 79d9bed.

📒 Files selected for processing (13)
  • Documentation/kernel.md (1 hunks)
  • buildroot-external/configs/generic_aarch64_defconfig (1 hunks)
  • buildroot-external/configs/generic_x86_64_defconfig (1 hunks)
  • buildroot-external/configs/green_defconfig (1 hunks)
  • buildroot-external/configs/khadas_vim3_defconfig (1 hunks)
  • buildroot-external/configs/odroid_c2_defconfig (1 hunks)
  • buildroot-external/configs/odroid_c4_defconfig (1 hunks)
  • buildroot-external/configs/odroid_m1_defconfig (1 hunks)
  • buildroot-external/configs/odroid_m1s_defconfig (1 hunks)
  • buildroot-external/configs/odroid_n2_defconfig (1 hunks)
  • buildroot-external/configs/odroid_xu4_defconfig (1 hunks)
  • buildroot-external/configs/ova_defconfig (1 hunks)
  • buildroot-external/configs/tinker_defconfig (1 hunks)
✅ Files skipped from review due to trivial changes (5)
  • buildroot-external/configs/ova_defconfig
  • buildroot-external/configs/tinker_defconfig
  • buildroot-external/configs/generic_aarch64_defconfig
  • Documentation/kernel.md
  • buildroot-external/configs/odroid_xu4_defconfig
🔇 Additional comments (8)
buildroot-external/configs/khadas_vim3_defconfig (1)

19-19: Verify kernel update and its implications

The kernel version update from 6.6.64 to 6.6.65 looks correct. Let's verify the changes and their implications.

✅ Verification successful

Kernel version update verified and consistent across configurations

The verification shows:

  • All defconfig files consistently use kernel version 6.6.65
  • The kernel changelog indicates this is a minor security/stability update that:
    • Reverts two problematic x86/pvh changes that caused boot failures in Xen domU guests
    • Includes an OpenRISC architecture optimization
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify kernel version consistency across all config files and check the changelog

# Test 1: Check kernel version consistency across all defconfig files
echo "Checking kernel version consistency across all defconfig files..."
rg -l "BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE=" buildroot-external/configs/ | \
  xargs rg "BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="

# Test 2: Fetch and display the kernel changelog
echo "Fetching kernel changelog..."
curl -s https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.6.65

Length of output: 4163

buildroot-external/configs/odroid_c4_defconfig (1)

19-19: LGTM: Kernel version update is consistent

The kernel version update to 6.6.65 matches the changes in other configuration files.

buildroot-external/configs/odroid_c2_defconfig (1)

19-19: LGTM: Kernel version update is consistent

The kernel version update to 6.6.65 matches the changes in other configuration files.

buildroot-external/configs/odroid_n2_defconfig (1)

19-19: LGTM: Kernel version update for Odroid N2

The kernel version update from 6.6.64 to 6.6.65 is consistent with the PR objective.

✅ Verification successful

LGTM: Kernel version update for Odroid N2 with verified config fragments

All required kernel configuration fragments (hassos.config, docker.config, device-support.config, device-support-wireless.config) are present in the correct location at buildroot-external/kernel/v6.6.y/. The kernel version update from 6.6.64 to 6.6.65 is safe to proceed.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify kernel config fragments exist and are valid
for fragment in hassos.config docker.config device-support.config device-support-wireless.config; do
  if [ ! -f "$(pwd)/kernel/v6.6.y/$fragment" ]; then
    echo "Missing kernel fragment: $fragment"
    exit 1
  fi
done

Length of output: 265


Script:

#!/bin/bash
# Let's first check if the kernel config directory exists and list its contents
fd -t d "kernel"

# Then list contents of any v6.6.y directory if found
fd -t d "v6.6" 

# Finally, let's search for these config files anywhere in the repository
fd "hassos\.config|docker\.config|device-support\.config|device-support-wireless\.config"

Length of output: 511

buildroot-external/configs/odroid_m1_defconfig (1)

19-19: LGTM: Kernel version update for Odroid M1

The kernel version update to 6.6.65 is consistent with other board configurations.

buildroot-external/configs/odroid_m1s_defconfig (1)

19-19: LGTM: Kernel version update for Odroid M1S

The kernel version update to 6.6.65 is consistent with other board configurations.

buildroot-external/configs/green_defconfig (1)

19-19: LGTM: Kernel version update to 6.6.65

The update from 6.6.64 to 6.6.65 is consistent with the PR objectives.

Let's verify the kernel version and changelog:

✅ Verification successful

Kernel version 6.6.65 verified with minor bug fixes and reverts

The changelog shows that Linux 6.6.65 is a legitimate kernel release from December 11, 2024, containing:

  • A cleanup change for OpenRISC architecture
  • Two reverts of Xen PVH-related changes that were causing boot failures in domU guests

These changes are typical for a stable kernel point release, focusing on bug fixes and stability improvements.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify kernel version 6.6.65 exists and fetch its changelog
# Expected results: 
# 1. Version exists in kernel.org
# 2. Changelog shows only bug fixes

# Check if the kernel version exists
curl -s https://www.kernel.org/releases.json | jq -r '.releases[] | select(.version == "6.6.65")'

# Fetch and display the changelog
curl -s https://cdn.kernel.org/pub/linux/kernel/v6.x/ChangeLog-6.6.65

Length of output: 2800

buildroot-external/configs/generic_x86_64_defconfig (1)

19-19: LGTM: Kernel version update to 6.6.65

The update from 6.6.64 to 6.6.65 is consistent with the PR objectives and matches the version update in other platform configurations.

Let's verify the consistency of this update across all platform configurations:

✅ Verification successful

Kernel version 6.6.65 is consistently set across all platform configurations

The verification confirms that all platform configuration files in buildroot-external/configs/ have been updated to use Linux kernel version 6.6.65, maintaining consistency across the entire codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify kernel version consistency across all platform configs
# Expected results: All configs should use version 6.6.65

# Search for kernel version declarations in all platform configs
rg "BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE=" buildroot-external/configs/

Length of output: 1201

@sairon sairon merged commit 7031870 into dev Dec 11, 2024
3 checks passed
@sairon sairon deleted the bump-linux-6.6.65 branch December 11, 2024 18:05
This was referenced Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board/generic-aarch64 Generic aarch64 machine board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) board/green Home Assistant Green board/khadas Khadas VIM Boards board/odroid Hardkernel's ODROID Boards board/ova Open Virtual Appliance (Virtual Machine) board/tinker ASUS' Tinker Boards cla-signed linux Linux kernel related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants