Disable UAS via usb-storage.quirks on RPi for JMicron JMS583 #3687
Conversation
Vendor ID: 152d Product ID: a583 fixes home-assistant#3674
📝 WalkthroughWalkthroughThe pull request introduces a modification to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
buildroot-external/board/raspberrypi/cmdline.txt (1)
1-1: Consider adding a comment to document this quirk.To help future maintainers, it would be valuable to document why this quirk was added, perhaps in a README or the kernel configuration documentation.
Example documentation:
+ # Documentation for USB quirks: + # 152d:a583:u - JMicron External USB3-to-NVMe adapter + # Added to resolve system stability issues (see #3674)🧰 Tools
🪛 LanguageTool
[uncategorized] ~1-~1: Probablemente falta un espacio.
Context: ...nsole=tty0 usb-storage.quirks=174c:55aa:u,2109:0715:u,152d:0578:u,152d:0579:u,152d:1561:u,1...(AI_ES_GGEC_MISSING_ORTHOGRAPHY_SPACE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
buildroot-external/board/raspberrypi/cmdline.txt(1 hunks)
🧰 Additional context used
🪛 LanguageTool
buildroot-external/board/raspberrypi/cmdline.txt
[uncategorized] ~1-~1: Probablemente falta un espacio.
Context: ...nsole=tty0 usb-storage.quirks=174c:55aa:u,2109:0715:u,152d:0578:u,152d:0579:u,152d:1561:u,1...
(AI_ES_GGEC_MISSING_ORTHOGRAPHY_SPACE)
🔇 Additional comments (1)
buildroot-external/board/raspberrypi/cmdline.txt (1)
1-1: LGTM! Verified vendor and product IDs.
The added quirk 152d:a583:u follows the correct format and matches JMicron's vendor ID. This should help resolve the stability issues reported in #3674 by disabling command queueing for this specific USB3-to-NVMe adapter.
Let's verify the vendor and product IDs against the USB ID database:
✅ Verification successful
Verified: JMicron vendor ID matches, product ID is within expected range
The vendor ID 152d is confirmed to belong to JMicron Technology Corp., which aligns with the USB-to-NVMe adapter mentioned in the PR. While the specific product ID a583 isn't listed in the public USB ID database (likely being a newer product), it follows JMicron's pattern of USB storage bridges, similar to their other products like JMS567 (152d:0567). The quirk's addition is appropriate for addressing the reported stability issues.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the USB vendor and product IDs
# Expected: Should find JMicron Technology Corp. as vendor
curl -s http://www.linux-usb.org/usb.ids | awk '/^152d/{p=NR+5}(NR<=p){print}'
Length of output: 361
🧰 Tools
🪛 LanguageTool
[uncategorized] ~1-~1: Probablemente falta un espacio.
Context: ...nsole=tty0 usb-storage.quirks=174c:55aa:u,2109:0715:u,152d:0578:u,152d:0579:u,152d:1561:u,1...
(AI_ES_GGEC_MISSING_ORTHOGRAPHY_SPACE)
sairon
added
board/raspberrypi
|
I don't know what. But according to the photos it uses a RTL9210B chip. According to the specs on the site however it uses a jms583. While jms583 seems likely, this page specifies that this chip can do TRIM but my Linux Notebook denied that, so I had to wipe it by writing zeros to it. https://www.jmicron.com/products/list/13 Here's the product: |
|
The VID is definitely of JMicron. According to the internet, JMS583 should have PID |
sairon
changed the title
Vendor ID: 152d
Product ID: a583
fixes #3674
Summary by CodeRabbit