Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NTFS and exFAT drivers for all targets #3516

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

lamauny
Copy link
Contributor

@lamauny lamauny commented Aug 11, 2024

No description provided.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lamauny

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft August 11, 2024 16:08
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to remove some options for the reasons said below. I understand the value of NTFS or exFAT, especially for people who want to share the removable drive with Windows machines, but some of those are rather improbable to be seen and enabling them would just increase the bloat in the system partition.

buildroot-external/kernel/v6.6.y/hassos.config Outdated Show resolved Hide resolved
buildroot-external/kernel/v6.6.y/hassos.config Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 12, 2024 17:51
@sairon sairon changed the title Add NTFS, exFAT and XFS kernel filesystems support (homeassistant#2723) Enable NTFS and exFAT drivers for all targets Aug 14, 2024
@sairon sairon marked this pull request as ready for review August 14, 2024 15:01
@home-assistant home-assistant bot requested a review from sairon August 14, 2024 15:02
@sairon sairon added the os label Aug 14, 2024
@sairon sairon merged commit 0c08acd into home-assistant:dev Aug 14, 2024
2 checks passed
This was referenced Aug 16, 2024
@felipecrs
Copy link

The release notes mentions this and it's a little catchy.

I really wonder what is the meaning of this in real life.

Does it mean we can do something we couldn't do before? Can we now plug NTFS drives in it and have them being recognized?

@trevornorcross
Copy link

The release notes mentions this and it's a little catchy.

I really wonder what is the meaning of this in real life.

Does it mean we can do something we couldn't do before? Can we now plug NTFS drives in it and have them being recognized?

I am also trying to understand this.

@codyrocco
Copy link

great!

@BasPost
Copy link

BasPost commented Aug 22, 2024

The release notes mentions this and it's a little catchy.

I really wonder what is the meaning of this in real life.

Does it mean we can do something we couldn't do before? Can we now plug NTFS drives in it and have them being recognized?

+1 Would like also to know. I just reinstalled my RPi setup tot Supervisor last weekend to have an external NTFS USB disk mounted.

@sairon
Copy link
Member

sairon commented Aug 22, 2024

Does it mean we can do something we couldn't do before? Can we now plug NTFS drives in it and have them being recognized?

See #2723. Not all targets had those drivers enabled in the kernel configs, now it's ensured they would be available consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants