Revert "Revert GRUB2 patch causing boot failure on some old x86_64 BIOSes (#3324)" #3470
+1
−303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OSes (#3324)" This reverts commit 478538e. For HAOS release 13.0 the patch that diverges our GRUB build from upstream to fix boot on some old Atom boards should be reverted. While this patch fixed issues on some boards, it significantly changes how the kernel is loaded with GRUB 2.12 and causes issues on other, more recent devices. There's a call to action for users of those old boards in #3305 to gather information which should result in upstream patch targeted specifically to the boards affected [1]. Fixes #3348 [1] https://lists.gnu.org/archive/html/grub-devel/2024-07/msg00009.html
frenck
approved these changes
Jul 10, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 478538e.
For HAOS release 13.0 the patch that diverges our GRUB build from upstream to fix boot on some old Atom boards should be reverted. While this patch fixed issues on some boards, it significantly changes how the kernel is loaded with GRUB 2.12 and causes issues on other, more recent devices. There's a call to action for users of those old boards in #3305 to gather information which should result in upstream patch targeted specifically to the boards affected [1].
Fixes #3348
[1] https://lists.gnu.org/archive/html/grub-devel/2024-07/msg00009.html