Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify expose_by_defaults in google_assistant #7292

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

zacs
Copy link
Contributor

@zacs zacs commented Oct 31, 2018

Description:
Minor update to Google Assistant configuration docs. Very minor, but very annoying if you try to be very explicit in your config.

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Oct 31, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 1, 2018
@fabaff fabaff merged commit 71d0d16 into home-assistant:current Nov 1, 2018
@ghost ghost removed the to-do label Nov 1, 2018
@frenck frenck added enhancement current This PR goes into the current branch labels Nov 1, 2018
glentakahashi added a commit to glentakahashi/home-assistant.io that referenced this pull request Nov 12, 2018
Now that home-assistant/core#17745 has been merged, the original documentation is back to being correct so the docs changes should be reverted once the version with home-assistant/core#17745 has been released.
frenck pushed a commit that referenced this pull request Nov 19, 2018
* Revert #7292

Now that home-assistant/core#17745 has been merged, the original documentation is back to being correct so the docs changes should be reverted once the version with home-assistant/core#17745 has been released.

* Add missing quote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants