Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intent_script component configuration #7154

Merged
merged 5 commits into from
Jan 15, 2019
Merged

Update Intent_script component configuration #7154

merged 5 commits into from
Jan 15, 2019

Conversation

klaasnicolaas
Copy link
Member

@klaasnicolaas klaasnicolaas commented Oct 27, 2018

Description:
Update style of Intent_script component documentation to follow new configuration variables description.
Related to #6385.

Note:
There are still a number of variables that are missing a description.

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Oct 27, 2018
@klaasnicolaas klaasnicolaas changed the title Update Intent_script component configuration WIP: Update Intent_script component configuration Oct 27, 2018
@frenck frenck added enhancement Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! in-progress This PR/Issue is currently being worked on current This PR goes into the current branch and removed to-do labels Oct 29, 2018
@klaasnicolaas
Copy link
Member Author

Who can help me think of some of description texts 🤔? I am not familiar with this component so I have no idea what I can put down 😄

@frenck
Copy link
Member

frenck commented Nov 11, 2018

@klaasnicolaas Not sure about your question here...
What exactly are you struggling with?

@klaasnicolaas
Copy link
Member Author

See the lines with: <- Need additional text>.

I added some new variables because they were not described before but they are in the python code. Only I have no idea what some variables do, so it is difficult to formulate a good description 😉

@frenck frenck self-assigned this Nov 12, 2018
@klaasnicolaas klaasnicolaas changed the title WIP: Update Intent_script component configuration Update Intent_script component configuration Dec 5, 2018
@ghost ghost added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Jan 15, 2019
@frenck
Copy link
Member

frenck commented Jan 15, 2019

@klaasnicolaas This took a while, sorry!

Updated the PR, what do you think?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klaasnicolaas Agreed (discussed per Discord).

@frenck frenck merged commit b9279b7 into home-assistant:current Jan 15, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jan 15, 2019
@thundergreen
Copy link
Contributor

I agree that there are almost no dics available . I wanna just post another example what's poosible and not documented:

  snips_fenster:
    sequence:
      service: snips.say
      data_template:
        text: >
             {% if is_state('group.windows_doors', 'on') %}
             Achtung! Folgende Fenster oder Türen sind noch offen: {{ dict((states|selectattr('entity_id', 'in', state_attr('group.windows_doors', 'entity_id'))|list)|groupby('state'))['on']|map(attribute='name')|list|join(', ') }}
             {% elif is_state('group.windows_doors', 'off') %}
             Alle Fenster und Türen sind geschlossen
             {% endif %}

This qill "enable" TTS with snips and this script checks for open windows in group.windows_doors and tells via TTS which windows / doors are open if no door or window is open --> A>nother message appears ( Alle Fenster und Türen sind geschlossen )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants