Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for json_attributes in command #5889

Merged
merged 2 commits into from
Jul 29, 2018
Merged

Add documentation for json_attributes in command #5889

merged 2 commits into from
Jul 29, 2018

Conversation

alexhardwicke
Copy link

@alexhardwicke alexhardwicke commented Jul 25, 2018 •
edited
Loading

Description:
Update documentation with an example using json_attributes in the Command line sensor.

Pull request in home-assistant (if applicable): home-assistant/core#15679

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Jul 25, 2018
@alexhardwicke alexhardwicke mentioned this pull request Jul 25, 2018
Merged
4 tasks
@DubhAd DubhAd added the has-parent This PR has a parent PR in a other repo label Jul 28, 2018
@ghost ghost assigned fabaff Jul 28, 2018
@ghost ghost added ready-for-review This PR needs to be reviewed and removed to-do labels Jul 28, 2018
fabaff
fabaff approved these changes Jul 28, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit eceee28 into home-assistant:next Jul 29, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jul 29, 2018
frenck added a commit that referenced this pull request Jul 29, 2018
@frenck
Revert "Add documentation for json_attributes in command (#5889)"
dbdf1e4 
This reverts commit eceee28.
@alexhardwicke alexhardwicke deleted the command_line_json_attrs branch July 29, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@fabaff fabaff

Labels
has-parent This PR has a parent PR in a other repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexhardwicke @fabaff @DubhAd