Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docs to add altitude changes #5652

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Updated docs to add altitude changes #5652

merged 2 commits into from
Aug 9, 2018

Conversation

miawgogo
Copy link
Contributor

@miawgogo miawgogo commented Jul 2, 2018

Description:
Updated docs to add altitude changes in openskys component

Pull request in home-assistant (if applicable): home-assistant/core#15273

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@miawgogo
Updated docs to add altitude changes
50cc50e 
relating to home-asssistant commit #15273
@ghost ghost added the to-do label Jul 2, 2018
@miawgogo miawgogo mentioned this pull request Jul 2, 2018
Merged
3 tasks
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed has-parent This PR has a parent PR in a other repo next This PR goes into the next branch and removed to-do labels Jul 2, 2018
@miawgogo
Copy link
Contributor Author

miawgogo commented Jul 3, 2018

that was a quick change to clarify the unit of mesurement

@frenck
Copy link
Member

frenck commented Jul 4, 2018

Looks good to me @ioangogo! 👍

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Jul 4, 2018
fabaff
fabaff approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 4650303 into home-assistant:next Aug 9, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miawgogo @frenck @fabaff