Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix details block in Bravia TV #23966

Merged
merged 7 commits into from
Sep 6, 2022
Merged

Conversation

Drafteed
Copy link
Contributor

@Drafteed Drafteed commented Aug 31, 2022

Proposed change

https://rc.home-assistant.io/integrations/braviatv/

It looks like the details block doesn't support code blocks.

Bugfix for: home-assistant/core#77329

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 31, 2022
@Drafteed Drafteed requested a review from bieniu as a code owner August 31, 2022 23:54
@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label Aug 31, 2022
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.
(message by DocsTargetBranch)

@Drafteed
Copy link
Contributor Author

Drafteed commented Aug 31, 2022

Please patch RC if needed.

@klaasnicolaas
Copy link
Member

What exactly is the purpose of this PR? I see a long list of options in the current documentation and you don't link to a pull request in the core integration?

@Drafteed
Copy link
Contributor Author

Drafteed commented Sep 2, 2022

@klaasnicolaas This is a bug fix made in my previous PR #23889.
At the moment it is only merged into next and rc, not current.

@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label Sep 2, 2022
@klaasnicolaas klaasnicolaas removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Sep 2, 2022
@klaasnicolaas klaasnicolaas added this to the 2022.9 milestone Sep 2, 2022
@klaasnicolaas
Copy link
Member

Thank you for explaining. I had to dig a bit to check if your core PR was in the release (it wasn't in the list), but should be fine and your docs PR is now tagged for the release 😉

@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration parent-merged The parent PR has been merged already and removed in-progress This PR/Issue is currently being worked on labels Sep 2, 2022
@klaasnicolaas
Copy link
Member

image

Maybe it's better not to make this in a list form but just string with commas?

@Drafteed
Copy link
Contributor Author

Drafteed commented Sep 2, 2022

but should be fine and your docs PR is now tagged for the release 😉

Thank you! 👍

Maybe it's better not to make this in a list form but just string with commas?

I thought about it, but it seemed to me that the list is more convenient and readable. Although one line is also good.

bieniu
bieniu previously approved these changes Sep 2, 2022
source/_integrations/braviatv.markdown Outdated Show resolved Hide resolved
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Drafteed 👍

@frenck frenck merged commit cdc1fa2 into home-assistant:next Sep 6, 2022
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Sep 6, 2022
@Drafteed Drafteed deleted the bravia-docs-fix branch September 6, 2022 18:59
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Sep 6, 2022
frenck pushed a commit that referenced this pull request Sep 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch cla-signed has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants