Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

It's all the same (mostly), just completely different. #268

Merged
merged 93 commits into from
Apr 27, 2019
Merged

It's all the same (mostly), just completely different. #268

merged 93 commits into from
Apr 27, 2019

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Apr 22, 2019

WIP!

Summary

  • hassbian-config has been rewritten and split into multiple files to make it more manageable.
  • A lot of functions have been moved from the script and into the base tool to make the shareable.
  • jq added as a new requirement.
  • All suites are now in separate directories.
  • All suites now have a manifest file to hold metadata.
  • Added workaround functions to handle known issues.
  • All rules for creating a PR is broken.
  • There is so much going on here that I cannot write it all down, for folks with special interest check the "Files changed" tab.
  • @Landrash wanted tests, so there is now a built-in test suite 🎉
    image

Still missing.

If (when) it is time to merge this, please use the "squash and merge" feature, the number of commits to this branch is disturbing 🙈

Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge into dev and continue testing there :)
First, second and third check looks good.

@ludeeus ludeeus marked this pull request as ready for review April 27, 2019 14:35
@ludeeus ludeeus merged commit 601a976 into home-assistant:dev Apr 27, 2019
@ludeeus ludeeus changed the title WIP: It's all the same (mostly), just completely different. It's all the same (mostly), just completely different. Apr 27, 2019
@ludeeus
Copy link
Member Author

ludeeus commented Apr 27, 2019

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants