Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Add install script for the Bluetooth monitor script #195

Merged
merged 5 commits into from
Oct 23, 2018
Merged

Add install script for the Bluetooth monitor script #195

merged 5 commits into from
Oct 23, 2018

Conversation

Landrash
Copy link
Collaborator

@Landrash Landrash commented Oct 14, 2018

Description:

Adds install script for the Bluetooth Montitor script by andrewjfreyer

** Depends on changes in #201 **

Checklist (Required):

If pertinent:

  • Script has validation check of the job.
  • Created/Updated documentation at /docs

package/opt/hassbian/suites/monitor.sh Outdated Show resolved Hide resolved
package/opt/hassbian/suites/monitor.sh Outdated Show resolved Hide resolved
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, I will probably have some time later today to test it :)

Since we now have remove option in the tool, maybe add a remove(cleanup) function too? :)
and maybe an upgrade function to fetch newest files from git?

package/opt/hassbian/suites/monitor.sh Outdated Show resolved Hide resolved
package/opt/hassbian/suites/monitor.sh Outdated Show resolved Hide resolved
@ludeeus
Copy link
Member

ludeeus commented Oct 14, 2018

I got some errors during the install:

Error: Required package 'hcidump' not found. Please install 'bluez-hcidump' (e.g                                                                             ., sudo apt-get install bluez-hcidump).
Error: Required package 'bc' not found. Please install 'bc' (e.g., apt-get install bc)

And when I tried starting the service it fails:

● monitor.service - Monitor Service
   Loaded: loaded (/etc/systemd/system/monitor.service; enabled; vendor preset: enabled)
   Active: activating (auto-restart) (Result: exit-code) since Sun 2018-10-14 19:18:36 UTC; 3s ago
  Process: 10060 ExecStart=/bin/bash /opt/monitor/monitor.sh & (code=exited, status=1/FAILURE)
 Main PID: 10060 (code=exited, status=1/FAILURE)

Oct 14 19:18:36 hassbian systemd[1]: monitor.service: Failed with result 'exit-code'.

It may be limited to my system, will try again with a fresh copy

@Landrash
Copy link
Collaborator Author

Landrash commented Oct 15, 2018 via email

@Landrash Landrash added the WIP Work In Progress label Oct 15, 2018
@Landrash
Copy link
Collaborator Author

I got some errors during the install:

Error: Required package 'hcidump' not found. Please install 'bluez-hcidump' (e.g                                                                             ., sudo apt-get install bluez-hcidump).
Error: Required package 'bc' not found. Please install 'bc' (e.g., apt-get install bc)

And when I tried starting the service it fails:

● monitor.service - Monitor Service
   Loaded: loaded (/etc/systemd/system/monitor.service; enabled; vendor preset: enabled)
   Active: activating (auto-restart) (Result: exit-code) since Sun 2018-10-14 19:18:36 UTC; 3s ago
  Process: 10060 ExecStart=/bin/bash /opt/monitor/monitor.sh & (code=exited, status=1/FAILURE)
 Main PID: 10060 (code=exited, status=1/FAILURE)

Oct 14 19:18:36 hassbian systemd[1]: monitor.service: Failed with result 'exit-code'.

It may be limited to my system, will try again with a fresh copy

Should work now by running with script or service.
Dependency changes are in #201 to address problems with general bluetooth components sine I did cleanups in that branch.

@Landrash Landrash removed the WIP Work In Progress label Oct 21, 2018
@Landrash
Copy link
Collaborator Author

@ludeeus I'll wait with removal and update until the upstream project gets a bit more stable since it currently is undergoing quite a few changes.

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this again after testing #201 and it works much better now 👍
I have added 1 suggestion :)

package/opt/hassbian/suites/monitor.sh Outdated Show resolved Hide resolved
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬

@ludeeus ludeeus merged commit 7a8f88e into home-assistant:dev Oct 23, 2018
@Landrash Landrash deleted the monitor branch October 23, 2018 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants