This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Cloud9: Added dedicated workspace and use symlink to homeassistant config. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landrash
suggested changes
Aug 17, 2018
| mkdir /home/homeassistant/c9workspace | ||
| ln -s /home/homeassistant/.homeassistant/ /home/homeassistant/c9workspace | ||
| ln -s /home/homeassistant/.c9 /home/homeassistant/c9workspace | ||
| mv /home/homeassistant/.homeassistant /home/homeassistant/homeassistant |
There was a problem hiding this comment.
This is a terrible idea. Create a symlink instead and both the default and the change will function.
We should always avoid changing defaults since other projects can assume that they are correct.
|
@Landrash Agreed! That would have been bad! |
Landrash
suggested changes
Aug 24, 2018
| mkdir /home/homeassistant/c9workspace | ||
| ln -s /home/homeassistant/.homeassistant/ /home/homeassistant/c9workspace | ||
| ln -s /home/homeassistant/.c9 /home/homeassistant/c9workspace | ||
| mv /home/homeassistant/c9workspace/.homeassistant /home/homeassistant/c9workspace/homeassistant |
There was a problem hiding this comment.
This line makes no sense to me?
The symlink created should be c9workspace and shouldn't contain this directory?
ludeeus
changed the title
|
I will find another way for this |
|
@Landrash does it look better now? |
Landrash
approved these changes
Sep 3, 2018
|
Looks good and can be merged after WIP tag is removed. |
ludeeus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uses /home/homeassistant/c9workspace as the workspace.
.homeassistant are symlinked to that workspace as
homeassistantctrl+e works for searching.
Related issue (if applicable): Fixes #177
Checklist (Required):
If pertinent:
/docs