This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
hassbian-config: Usage cleanup, added new help and command options. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Feb 24, 2018
| @@ -83,6 +97,10 @@ function share-log { | |||
| } | |||
|
|
|||
| function install-suite { | |||
| if [ "$(id -u)" != "0" ]; then | |||
| echo "This script must be run with sudo. Use \"sudo hassbian-config install "$1"\"" 1>&2 | |||
There was a problem hiding this comment.
The surrounding quotes actually unquote this. Remove or escape them.
Double quote to prevent globbing and word splitting.
| @@ -112,6 +130,10 @@ function install-suite { | |||
| } | |||
|
|
|||
| function upgrade-suite { | |||
| if [ "$(id -u)" != "0" ]; then | |||
| echo "This script must be run with sudo. Use \"sudo hassbian-config upgrade "$1"\"" 1>&2 | |||
There was a problem hiding this comment.
The surrounding quotes actually unquote this. Remove or escape them.
Double quote to prevent globbing and word splitting.
stickler-ci
reviewed
Feb 24, 2018
| @@ -83,6 +97,10 @@ function share-log { | |||
| } | |||
|
|
|||
| function install-suite { | |||
| if [ "$(id -u)" != "0" ]; then | |||
| echo "This script must be run with sudo. Use 'sudo hassbian-config install "$1"'" 1>&2 | |||
There was a problem hiding this comment.
The surrounding quotes actually unquote this. Remove or escape them.
Double quote to prevent globbing and word splitting.
| @@ -112,6 +130,10 @@ function install-suite { | |||
| } | |||
|
|
|||
| function upgrade-suite { | |||
| if [ "$(id -u)" != "0" ]; then | |||
| echo "This script must be run with sudo. Use 'sudo hassbian-config upgrade "$1"'" 1>&2 | |||
There was a problem hiding this comment.
The surrounding quotes actually unquote this. Remove or escape them.
Double quote to prevent globbing and word splitting.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
-Hand--helpto show the help menu.--version, as alias to-V--forceas alias to-f--acceptas alias to-yRelated issue (if applicable): Fixes #
Checklist:
If pertinent:
/docsScreenshot of the help function:
