Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Preparations for Stickler CI #112

Merged
merged 9 commits into from
Feb 17, 2018
Merged

Preparations for Stickler CI #112

merged 9 commits into from
Feb 17, 2018

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Feb 13, 2018

Description:

Initial issues: https://hastebin.com/mitewuseci
Related issue (if applicable): Fixes #110

Other

  • Removed "Info" function from cmd options. function does not exist
  • Where there is an validation, this line is removed if script is successful:
    "If you have issues with this script, please say something in the #devs_hassbian channel on Discord."
  • Added "show" to tab-complete.
  • Tabs used in scripts are now consistent, 2 spaces pr indent.
  • Added -y option to share-log

Checklist:

  • The code change is tested and works locally. with the exception of hassbian-config share-log

If pertinent:

  • [-] Created/Updated documentation at /docs
  • [-] Script has validation check of the job.

Local testing

Functions

  • hassbian-config show
  • hassbian-config show SUITE
  • hassbian-config show-installed
  • hassbian-config log
  • hassbian-config share-log http 503 error
  • hassbian-config -V
  • hassbian-config -y
  • hassbian-config -f
  • hassbian-config (defaults to usage)
  • hassbian-config install SUITE
  • hassbian-config upgrade SUITE

Scripts

  • appdaemon
  • duckdns
  • hassbian-script-dev
  • hassbian-script
  • homeassistant-dev
  • homeassistant
  • hassbian
  • homebridge
  • hue
  • libcec
  • mariadb
  • mosquitto
  • mssql
  • mysql
  • postgresql
  • razberry
  • samba
  • tradfri
  • webterminal

@ludeeus ludeeus added this to the v0.8.0 milestone Feb 13, 2018
@ludeeus ludeeus changed the title WIP: Preparations WIP: Preparations for Stickler CI Feb 13, 2018
Landrash
Landrash previously approved these changes Feb 14, 2018
Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite a bit less than expected 👍
Let's wait with merge until we fix the last one with the Homebridge address randomization.

@ludeeus
Copy link
Member Author

ludeeus commented Feb 15, 2018

Every script and the main tool is now compliant with https://stickler-ci.com/docs#bash
With the exception of SC1090

Landrash
Landrash previously approved these changes Feb 16, 2018
Copy link
Collaborator

@Landrash Landrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming local test run this is great!

@ludeeus ludeeus changed the title WIP: Preparations for Stickler CI Preparations for Stickler CI Feb 16, 2018
@Landrash Landrash merged commit 7e41fb4 into home-assistant:dev Feb 17, 2018
@ludeeus ludeeus deleted the stricker-ci branch February 19, 2018 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants