-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Statistics Graph card to integrate with Energy Dashboard (V2) #23478
Merged
MindFreeze
merged 9 commits into
home-assistant:dev
from
karwosts:statistics_date_picker
Jan 8, 2025
Merged
Enable Statistics Graph card to integrate with Energy Dashboard (V2) #23478
MindFreeze
merged 9 commits into
home-assistant:dev
from
karwosts:statistics_date_picker
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds boolean option `energy_date_selection` to Statistics Graph card. If true, the graph will set its time range to that specified by an Energy Date Picker card on the same dashboard, similar to the plots on the Energy Dashboard.
PR reviewer suggested it was too confusing, especially without dynamically hiding the overridden days_to_show option.
and instead activate when collection_key is specified
This reverts commit 95cebdb.
9 tasks
boern99
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it: works
MindFreeze
reviewed
Jan 8, 2025
MindFreeze
approved these changes
Jan 8, 2025
8 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Allows generic statistics graphs to follow the energy date selection picker, for building more interesting custom energy dashboards.
Picking up the changes from #21105, and attempt to fix the lingering comments related to that PR.
Type of change
Example configuration
Additional information
https://community.home-assistant.io/t/wth-dont-history-and-stats-graph-cards-have-a-date-time-picker/802788/6
Checklist
If user exposed functionality or configuration variables are added/changed: