Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Statistics Graph card to integrate with Energy Dashboard (V2) #23478

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Dec 27, 2024

Proposed change

Allows generic statistics graphs to follow the energy date selection picker, for building more interesting custom energy dashboards.

Picking up the changes from #21105, and attempt to fix the lingering comments related to that PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

madsciencetist and others added 8 commits June 24, 2024 13:49
Adds boolean option `energy_date_selection` to Statistics Graph card. If
true, the graph will set its time range to that specified by an Energy
Date Picker card on the same dashboard, similar to the plots on the
Energy Dashboard.
PR reviewer suggested it was too confusing, especially without
dynamically hiding the overridden days_to_show option.
and instead activate when collection_key is specified
Copy link
Contributor

@boern99 boern99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it: works

@MindFreeze MindFreeze merged commit b1acf9a into home-assistant:dev Jan 8, 2025
15 checks passed
@karwosts karwosts deleted the statistics_date_picker branch January 8, 2025 14:30
@karwosts karwosts added the WTH Issues & PRs generated from the "Month of What the Heck?" label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed WTH Issues & PRs generated from the "Month of What the Heck?"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants