Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility for people with red-green colourblindness #22365

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ThatBlockyPenguin
Copy link

@ThatBlockyPenguin ThatBlockyPenguin commented Oct 14, 2024

Proposed change

The icon used to communicate whether an addon is running or not is currently just a circle, and we rely on colour to communicate its status. This PR changes that, and makes the icon change when the addon starts/stops. This makes it easier for people with red-green colourblindness (like myself) to see at a glance, the status of the addon.

Running Not Running
Current image image
This PR image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

I am unsure how to get an instance of my PR running, if someone could point me to the right documentation, I will gladly run tests, though nothing should have changed functionally

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ThatBlockyPenguin

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 14, 2024 14:49
@github-actions github-actions bot added the Supervisor Related to the supervisor panel label Oct 14, 2024
@ThatBlockyPenguin ThatBlockyPenguin marked this pull request as ready for review October 14, 2024 15:02
@silamon
Copy link
Contributor

silamon commented Oct 14, 2024

Any particular reason why you choose mdiCircleOff for stopped instead of mdiStopCircle?

@ThatBlockyPenguin
Copy link
Author

Any particular reason why you choose mdiCircleOff for stopped instead of mdiStopCircle?

I was concerned it may look like a button to start and stop the addon, so I looked for alternatives. I couldn't find an icon I liked for "running" that was circular, other than that play icon, but mdiCircleOff was available for "not running" and I think it conveys an "off" state well. If you have any other icon suggestions I am open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hacktoberfest Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants