-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip failing Python 3.13 tests on musl #279
Conversation
5b8a27c
to
61f8da1
Compare
/CC @frenck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdce8p Why would we add a patch instead of setting the PROFILE_TASK
environment variable?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
What do you have in mind? Just setting it to an empty sting like the official docker image? That's possible but it also skips the tests entirely. I thought that it might be useful to continue running the tests during the build and therefore only patch the failing ones. https://docs.python.org/3/using/configure.html#envvar-PROFILE_TASK |
Opened #281 to disable the PGO tests completely. That's what the official docker image does. I'd prefer to just skip the failing tests (i.e. this PR) as it would help us notice any changes / new failures. However, both PRs would work. |
That makes total sense 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cdce8p 👍
../Frenck
No description provided.