Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment configuration for Stun server #87

Merged
merged 15 commits into from
Sep 27, 2024
Merged

Add deployment configuration for Stun server #87

merged 15 commits into from
Sep 27, 2024

Conversation

klejejs
Copy link
Contributor

@klejejs klejejs commented Sep 18, 2024

No description provided.

ludeeus
ludeeus reviewed Sep 23, 2024
View reviewed changes
stun_server/main.tf Outdated Show resolved Hide resolved
@klejejs klejejs force-pushed the task/add-stun-server-deployment-config branch from ca99ba5 to e2671fb Compare September 24, 2024 12:58
ludeeus
ludeeus reviewed Sep 25, 2024
View reviewed changes
.modules/webservice/dns.tf Outdated Show resolved Hide resolved
ludeeus
ludeeus reviewed Sep 25, 2024
View reviewed changes
.modules/service/ecs.tf Outdated Show resolved Hide resolved
@klejejs klejejs force-pushed the task/add-stun-server-deployment-config branch from ed1ead4 to d19aa7d Compare September 25, 2024 13:12
@klejejs klejejs closed this Sep 25, 2024
@klejejs klejejs reopened this Sep 25, 2024
ludeeus
ludeeus requested changes Sep 26, 2024
View reviewed changes
stun_server/region/module.tf Outdated Show resolved Hide resolved
stun_server/region/module.tf Outdated Show resolved Hide resolved
stun_server/region/module.tf Outdated Show resolved Hide resolved
stun_server/main.tf Outdated Show resolved Hide resolved
stun_server/main.tf Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 26, 2024 05:40
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@klejejs klejejs marked this pull request as ready for review September 26, 2024 08:26
@home-assistant home-assistant bot requested a review from ludeeus September 26, 2024 08:26
@klejejs klejejs force-pushed the task/add-stun-server-deployment-config branch from 85d37fa to d720513 Compare September 26, 2024 08:55
ludeeus
ludeeus reviewed Sep 26, 2024
View reviewed changes
stun_server/outputs.tf Outdated Show resolved Hide resolved
ludeeus
ludeeus reviewed Sep 26, 2024
View reviewed changes
stun_server/main.tf Outdated Show resolved Hide resolved
@klejejs klejejs force-pushed the task/add-stun-server-deployment-config branch from 967087c to d9220ed Compare September 26, 2024 14:31
@klejejs klejejs force-pushed the task/add-stun-server-deployment-config branch from f1330ef to 6034c27 Compare September 26, 2024 15:23
bemble
bemble previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@bemble bemble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@klejejs klejejs requested a review from ludeeus September 26, 2024 17:04
ludeeus
ludeeus reviewed Sep 27, 2024
View reviewed changes
stun_server/region/ecs.tf Outdated Show resolved Hide resolved
ludeeus
ludeeus reviewed Sep 27, 2024
View reviewed changes
stun_server/region/dns.tf Outdated Show resolved Hide resolved
bemble
bemble approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@bemble bemble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to check if the dependency between the DNS record and the interface is enough (what might happened is the network interface is created and attached, so TF moves on, but there's no public IP yet).

@klejejs klejejs requested a review from ludeeus September 27, 2024 12:47
@klejejs klejejs merged commit 1b9d95a into main Sep 27, 2024
3 checks passed
@klejejs klejejs deleted the task/add-stun-server-deployment-config branch September 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludeeus ludeeus ludeeus approved these changes

@bemble bemble bemble approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klejejs @bemble @ludeeus