Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl object logging to the profiler #93014

Closed
wants to merge 2 commits into from
Closed

Add ssl object logging to the profiler #93014

wants to merge 2 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 13, 2023

Proposed change

Add ssl object logging to the profiler as we are going to need more data since fixing this for good will likely come with a few iterations. Given the impact of the leak and how fast the memory is used, it seemed like it would be good to have something to help diagnose this issue in the future.

related PR #93013
related issue aio-libs/aiohttp#7252

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed now that the source of the issue has been discovered?

@bdraco
Copy link
Member Author

bdraco commented May 14, 2023

Is this still needed now that the source of the issue has been discovered?

Yes. It will be weeks or months before this is fixed properly in aiohttp and cpython so we will likely need data to confirm its really fixed once its done

@bdraco bdraco marked this pull request as draft May 14, 2023 19:28
@bdraco
Copy link
Member Author

bdraco commented May 14, 2023

Let's leave it as a draft. We can always wait to merge it until we have a case where a user still has the leak

@bdraco
Copy link
Member Author

bdraco commented May 15, 2023

It looks like cpython 3.11.4 is going to fix the underlying issue 👍

python/cpython#104485

Will keep this warm in case it doesn't but hopefully we can close it after bumping the images

@bdraco
Copy link
Member Author

bdraco commented May 15, 2023

Expected:

3.11.4: Monday, 2023-06-05

@bdraco
Copy link
Member Author

bdraco commented Jun 10, 2023

cpython 3.11.4 should fix the original leak that lead to this. Once we confirm it has gone away we can close this PR

@bdraco
Copy link
Member Author

bdraco commented Jun 18, 2023

Leak appears to be gone in 2023.6.2. Closing this

@bdraco bdraco closed this Jun 18, 2023
@bdraco bdraco deleted the ssl_profiler branch June 18, 2023 22:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants