-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssl object logging to the profiler #93014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed now that the source of the issue has been discovered?
Yes. It will be weeks or months before this is fixed properly in aiohttp and cpython so we will likely need data to confirm its really fixed once its done |
Let's leave it as a draft. We can always wait to merge it until we have a case where a user still has the leak |
It looks like cpython 3.11.4 is going to fix the underlying issue 👍 Will keep this warm in case it doesn't but hopefully we can close it after bumping the images |
Expected: 3.11.4: Monday, 2023-06-05 |
cpython 3.11.4 should fix the original leak that lead to this. Once we confirm it has gone away we can close this PR |
Leak appears to be gone in 2023.6.2. Closing this |
Proposed change
Add ssl object logging to the profiler as we are going to need more data since fixing this for good will likely come with a few iterations. Given the impact of the leak and how fast the memory is used, it seemed like it would be good to have something to help diagnose this issue in the future.
related PR #93013
related issue aio-libs/aiohttp#7252
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: