-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiohttp to 3.8.4 #88032
Bump aiohttp to 3.8.4 #88032
Conversation
changelog: aio-libs/aiohttp@v3.8.1...v3.8.4 Has aio-libs/aiohttp#7180 which is the fix we have been waiting for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
thanks |
This release of aiohttp still adopts the new behavior that view handlers now no longer get cancelled if the client leaves. See my comment here |
We need aiohttp 3.9 so we can use aio-libs/aiohttp#7056 which gives us the old behavior. |
So the new behavior means we don't cancelled the handler but instead rely on errors being raised when we send data to the client. This was broken in 3.8.3 but now works thanks to the fix by bdraco in 3.8.4 (previously we would just run out of memory). However, this new behavior means all view handlers are now behaving differently than before, and we haven't verified this (and need to verify this for all views? 😱). |
For more about the differences between the two, see https://github.com/aio-libs/aiohttp/blob/master/docs/web_advanced.rst#web-handler-cancellation |
Proposed change
changelog: aio-libs/aiohttp@v3.8.1...v3.8.4
Has aio-libs/aiohttp#7180 which is the fix we have been waiting for
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: