Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade aiohttp to 2.2.2 #8314

Merged
merged 2 commits into from
Jul 3, 2017
Merged

Upgrade aiohttp to 2.2.2 #8314

merged 2 commits into from
Jul 3, 2017

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jul 3, 2017 •
edited
Loading

2.2.2

  • Allow await session.close() along with yield from session.close()

2.2.1

Tested with:

http:

@pvizeli
Copy link
Member

pvizeli commented Jul 3, 2017

I think we should move to 2.2.2

@fabaff fabaff changed the title Upgrade aiohttp to 2.2.1 Upgrade aiohttp to 2.2.2 Jul 3, 2017
@fabaff fabaff merged commit afe3dd8 into dev Jul 3, 2017
@fabaff fabaff deleted the upgrade-aiohttp branch July 3, 2017 11:48
heinemml added a commit to heinemml/home-assistant that referenced this pull request Jul 6, 2017
@heinemml
mqtt: set client_id for default conf (fixes home-assistant#8314)
824fcf7 
This applies what was the intended fix in home-assistant#8336.

moves the fallback for setting client_id to the case when no mqtt config was provided at all. This should reflect the most common use case that fails.

This commit is a workaround and should be reverted when hbmqtt is fixed to allow empty client_id again.
@balloob balloob mentioned this pull request Jul 13, 2017
Merged
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@fabaff @dethpickle
Upgrade aiohttp to 2.2.2 (home-assistant#8314)
acfda21 
* Upgrade aiohttp to 2.2.1

* Upgrade to aiohttp to 2.2.2
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabaff @pvizeli @balloobbot @homeassistant