EntityComponent to retry platforms that are not ready yet #8209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli, @fabaff and @partofthething to be potential reviewers. |
|
I think we should back off to some longer interval (5 to 30 minutes), then retry perpetually. Especially if this is going to be opt-in by platforms. The big use-case is platforms that aren't available 24/7, and require a restart to pick up. If hass is only retrying for a short window after start up, this doesn't really fix it. The big concern is that as soon as you have more than one platform that has to be online during start up, it becomes trickier to find a window where everything is online and you can successfully start up. |
pvizeli
approved these changes
Jun 26, 2017
emlove
approved these changes
Jun 26, 2017
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
…tant#8209) * Add PlatformNotReady Exception * lint * Remove cap, adjust algorithm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds support for the entity component to retry setup of platforms that are not ready yet.
PlatformNotReadythat platforms can raise to opt-in for the built-in retry logic.EntityComponent catches this exception and will automatically retry the platform setup up to 10 times. Time between retries is 5, 10, 15, 20, 25 and 30 seconds after each retry after that.Related issue (if applicable): fixes #4937
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass