-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RainMachine config option to use default run times from app #80984
Add RainMachine config option to use default run times from app #80984
Conversation
Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@bachya Take a look and let me know if you can think of a better way to store/grab the values. I'll try and explain my reasoning here: The Because it's in a different update coordinator, and to not have to perform any intensive lookups at the time of a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! @bdraco, you want to weigh in further?
Proposed change
Adds an option to RainMachine for the integration to use the default per-zone run times a user has set in the RainMachine app when turning on a zone from Home Assistant.
Currently, the user can specify a default run time that all zones share when toggling the switch from the front end. If the new option is enabled, the integration uses the last manual watering time for each zone from the app.
Defaults to False to prevent breaking changes.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: