Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardware and fix raspberry pi brands in integrations.json #80970

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 25, 2022

Proposed change

Fixing a duplicate logo, and showing hardware in the add integrations dialog:

image

image

image

The hardware integrations are currently excluded, as consulted with @bramkragten, they are currently not used.

Additionally, the remote GPIO integration has no name? which is odd... it is also adjusted in this PR (the docs will sync up from the manifest).

After:

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@frenck frenck merged commit 98591cd into dev Oct 25, 2022
@frenck frenck deleted the frenck-2022-1976 branch October 25, 2022 19:05
@bramkragten bramkragten mentioned this pull request Oct 26, 2022
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple brand Icons not loading
2 participants