Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load themes from themes folder by default #80937

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Load themes from themes folder by default #80937

merged 1 commit into from
Oct 25, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Oct 25, 2022

Proposed change

Themes are generally distributed as files that are placed inside a themes folder. This is also the default behavior of HACS, which is kinda the defacto when it comes to distributing themes.

The problem is that by default, themes are not picked up by Home Assistant and require manual adjustment/YAML configuration by the end user.

This PR removes the need for that YAML edit and makes loading the themes folder a standard configuration. If the themes folder doesn't exist, it is simply ignored (until it exists on the next restart or themes reload).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner October 25, 2022 08:31
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 25, 2022
@frenck frenck merged commit 398d18e into dev Oct 25, 2022
@frenck frenck deleted the frenck-2022-1969 branch October 25, 2022 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core Hacktoberfest new-feature small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants