Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add week period to recorder statistics api #80784

Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Oct 22, 2022

Proposed change

This adds the week as new possible choice for statistics period

example based on demo data

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the issue, add the integration domain after the command.

@balloob
Copy link
Member

balloob commented Oct 22, 2022

Currently exploring replacing this API with data sources. Let's not expand this API until data sources idea is shot down

@mib1185 mib1185 force-pushed the recorder/add-week-period-to-statistics-api branch from efa590e to fcf8993 Compare October 22, 2022 18:16
@mib1185
Copy link
Contributor Author

mib1185 commented Oct 22, 2022

IMO the step from daily to monthly statistics is to big, so the weekly would fit perfect between both.
In my case I would like to have overviews over one year, for this a daily period is to much and monthly to less in resolution.
When will the data sources idea be ready?
Or is there any way to convince you to still extand the current API 😇

@balloob
Copy link
Member

balloob commented Oct 22, 2022

Here is the draft proposal for data sources.

You're not wrong about day -> month being a big step. @emontnemery thoughts?

@michelole
Copy link

I was planning to suggest exactly this feature --- nice to see a PR is ready! My use case is weather tracking and the weekly statistics would allow an easier comparison between e.g. current and past year.

@emontnemery
Copy link
Contributor

emontnemery commented Oct 25, 2022

I think this looks great!

Since this is PR about computing multiple weekly data point for display, I don't think it conflicts with the ideas for statistic data sources.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @mib1185 👍

@mib1185 mib1185 merged commit 8175dab into home-assistant:dev Oct 25, 2022
@mib1185 mib1185 deleted the recorder/add-week-period-to-statistics-api branch October 25, 2022 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants