-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add week period to recorder statistics api #80784
Add week period to recorder statistics api #80784
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Currently exploring replacing this API with data sources. Let's not expand this API until data sources idea is shot down |
efa590e
to
fcf8993
Compare
IMO the step from daily to monthly statistics is to big, so the weekly would fit perfect between both. |
Here is the draft proposal for data sources. You're not wrong about day -> month being a big step. @emontnemery thoughts? |
I was planning to suggest exactly this feature --- nice to see a PR is ready! My use case is weather tracking and the weekly statistics would allow an easier comparison between e.g. current and past year. |
I think this looks great! Since this is PR about computing multiple weekly data point for display, I don't think it conflicts with the ideas for statistic data sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @mib1185 👍
Proposed change
This adds the week as new possible choice for statistics period
example based on demo data
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: