Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use start helper in recorder #79559

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Use start helper in recorder #79559

merged 1 commit into from
Oct 25, 2022

Conversation

emontnemery
Copy link
Contributor

Proposed change

Use start helper in recorder

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

@emontnemery
Copy link
Contributor Author

emontnemery commented Oct 4, 2022

Tests fail because recorder was previously waiting for event EVENT_HOMEASSISTANT_STARTED but the start helper waits for event EVENT_HOMEASSISTANT_START.

Edit: Updated to use new at_started helper introduced by #79577

@emontnemery emontnemery force-pushed the recorder_use_start_helper branch from 1926ed1 to 537d3b2 Compare October 10, 2022 08:23
@frenck frenck force-pushed the recorder_use_start_helper branch from 537d3b2 to 0e0a05a Compare October 24, 2022 20:10
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 24, 2022
@emontnemery emontnemery merged commit beeee8b into dev Oct 25, 2022
@emontnemery emontnemery deleted the recorder_use_start_helper branch October 25, 2022 08:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality core Hacktoberfest integration: recorder small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants