Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iterable typing (2) #79296

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Improve iterable typing (2) #79296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a56f281
Improve iterable typing (2)
cdce8p Sep 29, 2022
caee6be
Use collection
cdce8p Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/homekit/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def __init__(
advertise_ip: str | None,
entry_id: str,
entry_title: str,
devices: Iterable[str] | None = None,
devices: list[str] | None = None,
) -> None:
"""Initialize a HomeKit object."""
self.hass = hass
Expand Down
4 changes: 2 additions & 2 deletions homeassistant/components/lifx/discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from __future__ import annotations

import asyncio
from collections.abc import Iterable
from collections.abc import Collection, Iterable

from aiolifx.aiolifx import LifxDiscovery, Light, ScanManager

Expand All @@ -17,7 +17,7 @@
DEFAULT_TIMEOUT = 8.5


async def async_discover_devices(hass: HomeAssistant) -> Iterable[Light]:
async def async_discover_devices(hass: HomeAssistant) -> Collection[Light]:
"""Discover lifx devices."""
all_lights: dict[str, Light] = {}
broadcast_addrs = await network.async_get_ipv4_broadcast_addresses(hass)
Expand Down